On 3/5/15 16:06, Geert Uytterhoeven wrote: > On Wed, Mar 4, 2015 at 8:49 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: >> --- a/drivers/of/unittest.c >> +++ b/drivers/of/unittest.c >> @@ -979,7 +979,7 @@ static int of_path_platform_device_exists(const char *path) >> return pdev != NULL; >> } >> >> -#if IS_ENABLED(CONFIG_I2C) >> +#if IS_BUILTIN(CONFIG_I2C) > > Wondering: is there any advantage in using "#if IS_BUILTIN(CONFIG_XXX)" > instead of "#ifdef CONFIG_XXX"? > For me, "#if IS_BUILTIN(CONFIG_XXX)" is better than "#ifdef CONFIG_XXX": - "#if IS_BUILTIN(CONFIG_XXX)" is only for CONFIG_XXX=y, and its name is also obvious. - "#ifdef CONFIG_XXX" may be for others, e.g. CONFIG_DEFCONFIG_LIST: .config:13:CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" include/generated/autoconf.h:1174:#define CONFIG_DEFCONFIG_LIST "/lib/modules/$UNAME_RELEASE/.config" And this time, arnd's patch is OK to me. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
