Hi Kanak, On 2024-07-01 7:13 AM, Kanak Shilledar wrote: > updated the struct of_device_id dw_spi_mmio_of_match to include > the updated compatible value for TH1520 SoC ("thead,th1520-spi") > to initialize with dw_spi_pssi_init(). > > Signed-off-by: Kanak Shilledar <kanakshilledar@xxxxxxxxx> > --- > Changes in v2: > - Separated from a single patch file. > --- > drivers/spi/spi-dw-mmio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c > index 819907e332c4..39e3d46ebf5d 100644 > --- a/drivers/spi/spi-dw-mmio.c > +++ b/drivers/spi/spi-dw-mmio.c > @@ -419,6 +419,7 @@ static const struct of_device_id dw_spi_mmio_of_match[] = { > { .compatible = "microchip,sparx5-spi", dw_spi_mscc_sparx5_init}, > { .compatible = "canaan,k210-spi", dw_spi_canaan_k210_init}, > { .compatible = "amd,pensando-elba-spi", .data = dw_spi_elba_init}, > + { .compatible = "thead,th1520-spi", .data = dw_spi_pssi_init}, Your binding requires snps,dw-apb-ssi as a fallback compatible string, which is already supported by this driver and uses the same match data. So you don't need this patch; its only effect is to make the kernel larger. Regards, Samuel > { /* end of table */} > }; > MODULE_DEVICE_TABLE(of, dw_spi_mmio_of_match);