On 29.06.2024 3:49 AM, Akhil P Oommen wrote: > To simplify, introduce the new gmu_chipid for a740 & a750 GPUs. > > Signed-off-by: Akhil P Oommen <quic_akhilpo@xxxxxxxxxxx> > --- This gets rid of getting patchid from dts, but I suppose that's fine, as we can just add a new entry to the id table [...] > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -771,7 +771,7 @@ static int a6xx_gmu_fw_start(struct a6xx_gmu *gmu, unsigned int state) > struct adreno_gpu *adreno_gpu = &a6xx_gpu->base; > const struct a6xx_info *a6xx_info = adreno_gpu->info->a6xx; > u32 fence_range_lower, fence_range_upper; > - u32 chipid, chipid_min = 0; > + u32 chipid = 0; The initialization doesn't seem necessary otherwise: Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad