Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Radxa ROCK 3B

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 27.06.24 um 00:29 schrieb FUKAUMI Naoki:
Hi,

thank you very much for your effort!

On 6/27/24 05:14, Jonas Karlman wrote:
The Radxa ROCK 3B is a single-board computer based on the Pico-ITX form
factor (100mm x 75mm). Two versions of the ROCK 3B exists, a community
version based on the RK3568 SoC and an industrial version based on the
RK3568J SoC.

Add initial support for eMMC, SD-card, Ethernet, HDMI, PCIe and USB.

Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx>
---
v2:
- Use regulator-.* nodename for fixed regulators
- Drop rockchip,mic-in-differential prop
- Shorten Ethernet phy reset-deassert-us to 50 ms
- Fix pcie pinctrl
- Add keep-power-in-suspend to sdmmc2

Following issue is reported by dtbs_check and is fixed by series at [1]:

   pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks'
     do not match any of the regexes: 'pinctrl-[0-9]+'
   from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#

[1] https://lore.kernel.org/all/20240622-rk809-fixes-v2-0-c0db420d3639@xxxxxxxxxxxxx/
---
  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
  .../boot/dts/rockchip/rk3568-rock-3b.dts      | 780 ++++++++++++++++++
  2 files changed, 781 insertions(+)
  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts

diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 90f5172f37e6..ae0ae02f51e9 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -114,6 +114,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-qnap-ts433.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-radxa-e25.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-roc-pc.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3b.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5.dtb
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-display-vz.dtbo
  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
new file mode 100644
index 000000000000..46c959f1c6ad
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
@@ -0,0 +1,780 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include "rk3568.dtsi"
+
+/ {
+    model = "Radxa ROCK 3B";
+    compatible = "radxa,rock-3b", "rockchip,rk3568";
+
+    aliases {
+        ethernet0 = &gmac0;
+        ethernet1 = &gmac1;
+        mmc0 = &sdhci;
+        mmc1 = &sdmmc0;
+        mmc2 = &sdmmc2;
+    };
+
+    chosen {
+        stdout-path = "serial2:1500000n8";
+    };
+
+    hdmi-con {
+        compatible = "hdmi-connector";
+        type = "a";
+
+        port {
+            hdmi_con_in: endpoint {
+                remote-endpoint = <&hdmi_out_con>;
+            };
+        };
+    };
+
+    ir-receiver {
+        compatible = "gpio-ir-receiver";
+        gpios = <&gpio0 RK_PC2 GPIO_ACTIVE_LOW>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&pwm3_ir>;
+    };
+
+    leds {
+        compatible = "gpio-leds";
+
+        led-green {

led-0 or just led (leds-gpio.yaml)

That's a misinterpretation of the pattern-properties regex: The
"non-preferred" part of the regex does neither have a "^" nor an "$", thus
it allows all nodes names which have "led" somewhere.
Best regards,

--
FUKAUMI Naoki





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux