On Wed, Jun 26, 2024 at 2:12 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 24/06/2024 14:13, George Chan via B4 Relay wrote: > > From: George Chan <gchan9527@xxxxxxxxx> > > > > Add bindings for qcom,sc7180-camss in order to support the camera > > subsystem for sm7125 as found in the Xiaomi Redmi 9 Pro cellphone. > > > ... > > > + > > +required: > > + - clock-names > > + - clocks > > + - compatible > > Nothing improved here. > > I asked you at v2 to go through all comments and respond to each of them > or implement each of them. > >>> Keep the list ordered, the same as list properties. I am a bit confused. Is it by ascending order or by particular order like below the same ordering to the example node? required: - compatible - reg - reg-names - clock-names - clocks > BTW, I asked for subject to keep only one, first "media" prefix: > "Subject: just one media (first). " > but you kept the second "media". Sorry I can't get it. Could you choose one? _ORIGINAL_ dt-bindings: media: camss: Add qcom,sc7180-camss _PREFERED_ media: camss: dt-bindings: Add qcom,sc7180-camss _OR_ dt-bindings: media: Add qcom,sc7180-camss > > > Best regards, > Krzysztof >