Hello Kelvin, On Tue, Jun 25, 2024 at 05:33:22PM +0800, Kelvin Zhang wrote: > On 2024/6/17 22:11, Uwe Kleine-König wrote: > > On Mon, Jun 17, 2024 at 04:44:13PM +0800, Junyi Zhao wrote: > > > > > So yes, please use dev_err_probe() also to handle > > > > > devm_add_action_or_reset(). > > > > My point here is also that devm_add_action_or_reset() can only fail on > > > > memory allocation, like (devm_)kzalloc. Looking around the kernel, we > > > > tend to not add messages for that and just return the error code, > > > > presumably because those same 'out of memory' messages would proliferate > > > > everywhere. > > > Hi Uwe, I didnt get the clear point. > > > So, if we need "return ret" directly? or keep "dev_err_probe()" to print? > > Please keep the dev_err_probe(). There is a problem with that approach > > (as Jerome pointed out), but that is about to be addressed in driver > > core code. FTR, this is done in https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=2f3cfd2f4b7cf3026fe6b9b2a5320cc18f4c184e > For this patchset, is there anything that needs improvement? It's on my (not particularily short) todo list to review this patch. I'm aware there are several people waiting for that one. I intend to work on this one later this week. Best regards Uwe
Attachment:
signature.asc
Description: PGP signature
