… > Signed-off-by: keith <keith.zhao@xxxxxxxxxxxxxxxx> Should the personal name be more unique (according to the Developer's Certificate of Origin)? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n438 … > +++ b/drivers/gpu/drm/bridge/innosilicon/inno-hdmi.c > @@ -0,0 +1,587 @@ … > +static int inno_hdmi_i2c_xfer(struct i2c_adapter *adap, > + struct i2c_msg *msgs, int num) > +{ … > + mutex_lock(&i2c->lock); > + > + /* Clear the EDID interrupt flag and unmute the interrupt */ … > + hdmi_writeb(hdmi, HDMI_INTERRUPT_MASK1, 0); > + > + mutex_unlock(&i2c->lock); > + > + return ret; > +} … Would you become interested to apply a statement like “guard(mutex)(&i2c->lock);”? https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196 Regards, Markus
