Re: [PATCH 4/9] dt-bindings: iio: adc: adi,ad7606: add supply properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 18 Jun 2024 18:32:20 +0100
Conor Dooley <conor@xxxxxxxxxx> wrote:

> On Tue, Jun 18, 2024 at 05:33:16PM +0200, Guillaume Stols wrote:
> > 
> > On 6/18/24 17:12, Conor Dooley wrote:  
> > > On Tue, Jun 18, 2024 at 02:02:36PM +0000, Guillaume Stols wrote:  
> > > > Add voltage supplies  
> > > Are these available on all devices?  
> > 
> > Yes all chips from  AD7606 series (including AD7606B, AD7606C(-16,-18),
> > AD7605-4, AD7606 (-4,-8,-6), AD7607, AD7608, AD7609), as well as AD7616
> > have a VDrive pin, as well as a RefSelect + RefIn/RefOut pin that takes
> > an input voltage in case RefSelect is high, or outputs the internal
> > reference voltage if RefSelect is low.  
> 
> Okay,
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> provided that...

Sounds like vdrive-supply is a requirement for the device to function but
refin may be optional.

So add vdrive-supply to the required property list.

Note the binding for supplies reflects what must be wired and ignores
the ability of the linux regulator framework to get fake supplies when
they are not provided in DT.

> 
> >   
> > >   
> > > > Signed-off-by: Guillaume Stols <gstols@xxxxxxxxxxxx>
> > > > ---
> > > >   Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 9 +++++++++
> > > >   1 file changed, 9 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > > > index 80866940123c..e480c9a7c7ca 100644
> > > > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > > > @@ -35,6 +35,15 @@ properties:
> > > >     avcc-supply: true
> > > > +  vdrive-supply:  
> 
> The lack of a blank line here is an artifact of the reply
> 
> > > > +    description:
> > > > +      Determines the voltage level at which the interface logic pins will
> > > > +      operate.
> > > > +
> > > > +  refin-supply:
> > > > +    description:
> > > > +      The voltage supply for optional external reference voltage.
> > > > +
> > > >     interrupts:
> > > >       description:
> > > >         The BUSY pin falling edge indicates that the conversion is over, and thus
> > > > 
> > > > -- 
> > > > 2.34.1
> > > >   






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux