On 21/06/2024 06:27, Chris Packham wrote: > Add the rtl930x-soc and RTL9302C board to the list of Realtek compatible > strings. No, you did not do this. You added fallback, without any rationale. > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/mips/realtek-rtl.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml > index f8ac309d2994..f59249a2cefe 100644 > --- a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml > +++ b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml > @@ -19,6 +19,8 @@ properties: > - items: > - enum: > - cisco,sg220-26 > + - realtek,RTL9302C > - const: realtek,rtl8382-soc > + - const: realtek,rtl930x-soc Does not look right. First: Not tested. Second: does not really make sense and commit msg does not explain it to me. Also, no wildcards. Best regards, Krzysztof
