On Wed, 2015-03-04 at 10:53 +0100, Arnd Bergmann wrote: > On Wednesday 04 March 2015 10:31:07 Yingjoe Chen wrote: > > Hi, > > > > Since we support devicetree, we don't need MACH_* to build a working > > kernel. This is true even for our v7 soc. We intend to use it to reduce > > numbers of drivers in product kernel binary. > > Most drivers are shared among the same SoCs family, but some are not. > > Currently for pinctrl driver, we are doing this so user don't need to > > select them one by one: > > > > config PINCTRL_MT8173 > > def_bool MACH_MT8173 > > select PINCTRL_MTK_COMMON > > > > Alternatively, we could add these MACH_* to some other places, eg, > > drivers/soc/mediatek. Or we don't add MACH_* at all, and have all > > drivers export their own Kconfig option. User will need to select each > > of them one-by-one. > > > > What do you think? > > I would rather see these as user-selectable options, which has the > other benefit of giving compile-time coverage. For your example, > I'd suggest doing > > config PINCTRL_MT8173 > bool "Mediatek MT8173 pin control" > depends on ARCH_MEDIATEK || COMPILE_TEST > select PINCTRL_MTK_COMMON > help > ... a useful description ... > OK, I'll send a new patch to do this. Thanks. Joe.C -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
