On Tue 03 Mar 10:56 PST 2015, Stephen Boyd wrote:
> On 03/02/15 20:25, Bjorn Andersson wrote:
> > +
> > +static int rpm_reg_probe(struct platform_device *pdev)
> > +{
> > + struct regulator_init_data *initdata;
> > + const struct qcom_rpm_reg *template;
> > + const struct of_device_id *match;
> > + struct regulator_config config = { };
> > + struct regulator_dev *rdev;
> > + struct qcom_rpm_reg *vreg;
> > + const char *key;
> > + u32 val;
> > + int ret;
> > +
> > + match = of_match_device(rpm_of_match, &pdev->dev);
> > + template = match->data;
> > +
> > + vreg = devm_kmalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL);
> > + if (!vreg) {
> > + dev_err(&pdev->dev, "failed to allocate vreg\n");
>
> We don't need error messages on allocation failures.
>
Right, it's just that I wanted to keep these patches free from any
unrelated changes. I can add an extra patch at the end removing this and
moving the retrieval of rpm out of the for loop.
> > + return -ENOMEM;
> > + }
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
