On Wed, Jun 19, 2024 at 12:12:30PM +0100, Conor Dooley wrote: > On Sat, Jun 15, 2024 at 06:54:29PM -0700, Drew Fustini wrote: > > This series adds support for the AP sub-system clock controller in the > > T-Head TH1520 [1]. Yangtao Li originally submitted this series in May > > 2023 [2]. Jisheng made additional improvements and then passed on the > > work in progress to me. > > One thing I noticed on the dts side is that the GPIO controllers have no > clocks provided. Does the AP sub-system clock controller provide their > clocks too? Good question. I see that dwapb_get_clks() in drivers/gpio/gpio-dwapb.c does call devm_clk_bulk_get_optional() for "bus" and "db". There doesn't seem to be to many in-tree examples of clocks being defined for gpio controllers with compatible "snps,dw-apb-gpio", but I do see that k210.dtsi defines K210_CLK_APB0 for "bus" and K210_CLK_GPIO for "db".
