Hi, This series enables Hantro support for RK3588. It is based on these two previous series from Emmanuel Gil Peyrot and Jianfeng Liu, which looked stalled to me. Considering the full driver is already upstream, I think this low hanging fruit should be enabled in 6.11: * https://lore.kernel.org/all/20240316071100.2419369-1-liujianfeng1994@xxxxxxxxx/ * https://lore.kernel.org/linux-rockchip/20240412151515.837824-1-linkmauve@xxxxxxxxxxxx/ Their series got some feedback from Nicolas Dufresne, that there should be a plan how multi-core processing will be handled once it is supported in the kernel. I had a look (and internal discussion with Nicolas) and came up with a patch, which allows describing all the Hantro IP in DT. The driver will only probe for the first instance. This involves dropping the RK3568 compatible for the VEPU121, so that only kernels with the driver change will try to handle these IP. Once the kernel is capable of multi-core support, the same technique to disable cores 1-3 can be used to combine them all into one cluster. We also discussed, if they should be described as a cluster (e.g. by creating some kind of virtual bus for the 4 encoders in DT). Apparently the VSI doc describes the grouping of up to 4 instances. But there is no obvious reason why only these groups can be used as a cluster. It seems that even the 5th encoder from the combo VPU121 could be used together with the other clustered cores in theory. In practice this is probably a bad idea because of the shared cache of that encoder. Since that is handled with a different compatible, this can be thought about at a later point of time and handled in the kernel. Thus no special cluster description is needed in DT. Changes since PATCHv6: * Collected Acked-by for RK3588 VEPU121 DT binding from Conor Dooley * Fix resource leak of DT node in hantro_disable_multicore() * Support disabled nodes in hantro_disable_multicore() * Use correct match data (RK3568 VEPU instead of VPU) for RK3588 VEPU121 Changes since PATCHv5: * Fix binding for vepu121 (use enum) * split hantro driver patch (multicore / vepu121 compatible) * move video-codec@fdb50000 node to correct position * change "jpeg_enc*" alias to "vepu121_*" * change "vpu_*" alias to "vpu121_*" (to be consistent) Changes since PATCHv3 (VEPU121) / PATCHv4 (VPU121) * combine both patchsets, since there is some overleap * add patch to disable multi-core handling in the hantro driver * drop the RK3568 fallback compatible for VEPU (see above for the reason) * describe all RK3588 VEPU cores (possible because of driver change) Greetings, -- Sebastian Emmanuel Gil Peyrot (2): media: dt-bindings: rk3568-vepu: Add RK3588 VEPU121 arm64: dts: rockchip: Add VEPU121 to RK3588 Jianfeng Liu (2): media: dt-bindings: rockchip-vpu: Add RK3588 VPU121 arm64: dts: rockchip: Add VPU121 support for RK3588 Sebastian Reichel (2): media: hantro: Disable multicore support media: hantro: Add RK3588 VEPU121 .../bindings/media/rockchip,rk3568-vepu.yaml | 1 + .../bindings/media/rockchip-vpu.yaml | 3 + arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 101 ++++++++++++++++++ .../media/platform/verisilicon/hantro_drv.c | 48 +++++++++ 4 files changed, 153 insertions(+) -- 2.43.0
