On 17/06/2024 14:59, Dimitri Fedrau wrote: > Am Sun, Jun 16, 2024 at 09:27:21AM +0200 schrieb Krzysztof Kozlowski: >> On 15/06/2024 22:33, Dimitri Fedrau wrote: >>> Adding documentation for MAXIMs MAX17201/MAX17205 fuel gauge. >>> >> >> Three patchsets within 30 minutes. No changelog et all. >> > Sorry, had to fix my mail address in the commit message. Changelog was > in the cover letter. Anyway, could have fixed that in a later version. There was no cover letter attached to this patchset. If you do not send cover letter to interested parties, then it does not count. > >> Slow down (one posting per 24h) to give people chances to review. Then >> provide changelog under --- and describe what happened. >> > [...] >>> +maintainers: >>> + - Dimitri Fedrau <dima.fedrau@xxxxxxxxx> >>> + >>> +properties: >>> + - description: ModelGauge m5 registers >>> + - description: Nonvolatile registers >>> + >>> + reg-names: >>> + items: >>> + - const: m5 >>> + - const: nvmem >>> + >>> + interrupts: >>> + maxItems: 1 >> >> This is incomplete. Missing battery and probably more... Look how other >> bindings are written. >> > Some fuel gauges used monitored-battery and/or power-supplies others none > of them(mitsumi,mm8013.yaml). I'm not sure when to use them. Look at your hardware, datasheet if it is available. Then look at monitored battery properties. If you see anything in common, then that's a sign. I did not get your driver changes, so I cannot help here. Kind of your call. Best regards, Krzysztof
