On 15/06/2024 22:33, Dimitri Fedrau wrote: > Adding documentation for MAXIMs MAX17201/MAX17205 fuel gauge. > Three patchsets within 30 minutes. No changelog et all. Slow down (one posting per 24h) to give people chances to review. Then provide changelog under --- and describe what happened. > Signed-off-by: Dimitri Fedrau <dima.fedrau@xxxxxxxxx> > --- > .../bindings/power/supply/maxim,max1720x.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml > new file mode 100644 > index 000000000000..4414bc6f214f > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/maxim,max1720x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX1720x fuel gauge > + > +maintainers: > + - Dimitri Fedrau <dima.fedrau@xxxxxxxxx> > + > +properties: > + compatible: > + const: maxim,max1720x Nope, this must be specific. Filename follows compatible then. > + > + reg: > + items: > + - description: ModelGauge m5 registers > + - description: Nonvolatile registers > + > + reg-names: > + items: > + - const: m5 > + - const: nvmem > + > + interrupts: > + maxItems: 1 This is incomplete. Missing battery and probably more... Look how other bindings are written. > + > +required: > + - compatible > + - reg > + - reg-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + max17201@36 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "maxim,max1720x"; > + reg = <0x36>, <0xb>; > + reg-names = "m5", "nvmem"; > + interrupt-parent = <&gpio0>; > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; > + status = "okay"; Drop Best regards, Krzysztof
