Hi Geert, On Thu, Jun 13, 2024 at 4:15 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Krzysztof, > > On Thu, Jun 13, 2024 at 2:56 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 13/06/2024 11:57, Lad, Prabhakar wrote: > > >>> of section 4.4.2 which cannot be controlled by CLKON register. > > >>> --- > > >>> include/dt-bindings/clock/r9a09g057-cpg.h | 21 +++++++++++++++++++++ > > >>> 1 file changed, 21 insertions(+) > > >>> create mode 100644 include/dt-bindings/clock/r9a09g057-cpg.h > > >> > > >> Missing vendor prefix. > > >> > > > OK, Is this just for new includes being added, or do you want me to > > > rename the existing Renesas specific includes in here which dont have > > > vendor prefix? > > > > Didn't we discuss it? > > > > I commented only about this binding. > > Yes we did, in the context of the R-Car V4M DT binding definitions, > which became include/dt-bindings/clock/renesas,r8a779h0-cpg-mssr.h > But Prabhakar was not involved there. > > Note that I also asked to include the vendor prefix, see > https://lore.kernel.org/linux-renesas-soc/CAMuHMdU7+O-+v=2V83AjQmTWyGy_a-AHgU_nPMDHnVUtYt89iQ@xxxxxxxxxxxxxx/ > Oops I missed that review comment. Cheers, Prabhakar