On Tue, Jun 11, 2024 at 02:49:07PM +0200, Thomas Bogendoerfer wrote: > On Tue, Jun 11, 2024 at 01:35:33PM +0200, Christian Marangi wrote: > > It was discovered that some device have CBR address set to 0 causing > > kernel panic when arch_sync_dma_for_cpu_all is called. > > > > This was notice in situation where the system is booted from TP1 and > > BMIPS_GET_CBR() returns 0 instead of a valid address and > > !!(read_c0_brcm_cmt_local() & (1 << 31)); not failing. > > > > The current check whether RAC flush should be disabled or not are not > > enough hence lets check if CBR is a valid address or not. > > > > Fixes: ab327f8acdf8 ("mips: bmips: BCM6358: disable RAC flush for TP1") > > should I apply it to mips-fixes ? If not could you just ammend > it with the following patch, where this is changed again ? > Ideally this should be backported to stable kernel since it does cause kernel panic. This is why it's split and it's the first patch of the series. -- Ansuel