On Thu, Jun 6, 2024 at 6:23 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Wed, Jun 05, 2024 at 04:52:55PM +0530, Animesh Agarwal wrote: > > Convert the dummy SPDIF receiver bindings to DT schema. Make bindings > > complete by adding property "#sound-dai-cells" > > 2 conversions of the same thing in one day: > > https://lore.kernel.org/all/20240605-topic-amlogic-upstream-bindings-convert-spdif-receiver-v1-1-262465adbac2@xxxxxxxxxx/ > > As I said there, I would just add the compatible to > linux,spdif-dit.yaml. But this is fine too. > > > > > Signed-off-by: Animesh Agarwal <animeshagarwal28@xxxxxxxxx> > > Cc: Daniel Baluta <daniel.baluta@xxxxxxx> > > --- > > .../bindings/sound/linux,spdif-dir.yaml | 34 +++++++++++++++++++ > > .../bindings/sound/spdif-receiver.txt | 10 ------ > > 2 files changed, 34 insertions(+), 10 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml > > delete mode 100644 Documentation/devicetree/bindings/sound/spdif-receiver.txt > > > > diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml b/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml > > new file mode 100644 > > index 000000000000..61767873200f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml > > @@ -0,0 +1,34 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/linux,spdif-dir.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Dummy SPDIF receiver > > + > > +maintainers: > > + - Liam Girdwood <lgirdwood@xxxxxxxxx> > > + - Mark Brown <broonie@xxxxxxxxxx> > > + > > +allOf: > > + - $ref: dai-common.yaml# > > + > > +properties: > > + compatible: > > + const: linux,spdif-dir > > + > > + "#sound-dai-cells": > > + const: 0 > > It wasn't in the txt binding, but users also use 'sound-name-prefix' > property, so that should be added here. linux,spdif-dir.yaml If this is the case, I'll add the linux,spdif-dir compatible in linux,spdif-dit.yaml instead of creating a new file in v2 of this patch. Regards, Animesh Agarwal
