Hii Prabhakar, Thanks for your patch! On Fri, May 24, 2024 at 10:29 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Add RZ/V2H(P) CPG helper driver. Drop "helper"? > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > --- /dev/null > +++ b/drivers/clk/renesas/r9a09g057-cpg.c > @@ -0,0 +1,112 @@ > +static int pll_clk1_offset[] = { -EINVAL, -EINVAL, -EINVAL, 0x64, -EINVAL, > + -EINVAL, 0xC4, -EINVAL, -EINVAL, 0x124, 0x144 }; > +static int pll_clk2_offset[] = { -EINVAL, -EINVAL, -EINVAL, 0x68, -EINVAL, > + -EINVAL, 0xC8, -EINVAL, -EINVAL, 0x128, 0x148 }; const (both) Both arrays are very similar: all valid values differ by an offset of 4. If that is universal, perhaps the second one can be dropped, and the offset can be handled by the user? > +static struct rzv2h_mod_clk r9a09g057_mod_clks[] = { const > + DEF_MOD("scif_0_clk_pck", R9A09G057_SCIF_0_CLK_PCK, CLK_PLLCM33_DIV16, > + 0x620, 15, 0x810, 15), > +}; > + > +static struct rzv2h_reset r9a09g057_resets[] = { const > + DEF_RST(R9A09G057_SCIF_0_RST_SYSTEM_N, 0x924, 5, 0xA10, 6), > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds