Re: [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Niklas,

On Mon, May 27, 2024 at 3:20 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> Document support for the ISP module in the Renesas V4M (r8a779h0) SoC.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/media/renesas,isp.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,isp.yaml
> @@ -22,6 +22,7 @@ properties:
>        - enum:
>            - renesas,r8a779a0-isp # V3U
>            - renesas,r8a779g0-isp # V4H
> +          - renesas,r8a779h0-isp # V4M
>    reg:
>      maxItems: 1

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

BTW, this binding only describes a single register block, while the
ISP seems to have two: CS and CORE (the second one is optional, as it
does not exist for the second instance of R-Car V4M)?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds