On Tue, Jun 04, 2024 at 08:21:32AM +0200, Krzysztof Kozlowski wrote: > On 04/06/2024 04:51, Kent Gibson wrote: > > On Sun, Jun 02, 2024 at 10:33:08PM +0200, Linus Walleij wrote: > >> From: Nicola Di Lieto <nicola.dilieto@xxxxxxxxx> > >> > >> Add bindings for PWM modulated by GPIO. > >> > > > > Shouldn't the bindings be added after the driver? > > No. See submitting patches document. > Hmmm, ok, so "5. The Documentation/ portion of the patch should come in the series before the code implementing the binding."[1]? It just seems odd that you document something that doesn't exist yet. Cheers, Kent. [1] https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html