From: Jonathan Cameron <jic23@xxxxxxxxxx> Sent: 02 June 2024 15:16 To: Arthur Becker Cc: Krzysztof Kozlowski; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx Subject: Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings > On Tue, 28 May 2024 07:23:03 +0000 > Arthur Becker <arthur.becker@xxxxxxxxxx> wrote: > > > Thanks for the Review! > > Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file. > > I'll modify that the next time I make adjustments to the driver. > > Hi Arthur, > > If I read the above correctly you are hoping this merges as it stands and > we come back later. If we are going to combine them long term, > I'd rather we avoided the churn and had a combined DT binding from the start. Hi Jonathan, I could have phrased that better, what I meant was that I was waiting for the next feedback on the driver to make the adjustments all at once. I'll get to it shortly! Kind Regards, Arthur > > Jonathan > > > > > Kind regards, > > Arthur > > > > ________________________________________ > > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > Sent: 27 May 2024 18:31 > > To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley > > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > > Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings > > > > On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote: > > > From: Arthur Becker <arthur.becker@xxxxxxxxxx> > > > > > > Device tree bindings for the vishay VEML6040 RGBW light sensor iio > > > driver > > > > > > Signed-off-by: Arthur Becker <arthur.becker@xxxxxxxxxx> > > > --- > > > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent > > > along with v2 of the driver but not in a set) > > > > It's basically the same as veml6075, so should be put there... > > > > Eh, > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > > Best regards, > > Krzysztof > >