On 31/05/2024 15:09, Guenter Roeck wrote: > On 5/31/24 01:15, Krzysztof Kozlowski wrote: >> On 31/05/2024 00:39, Guenter Roeck wrote: >>> Add device tree bindings for the SPD hub present in DDR5 modules. >>> >>> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> >> >> ... >> >>> +title: JEDEC JESD300-5B (SPD5118) compatible DDR5 SPD hub >>> + >>> +maintainers: >>> + - Guenter Roeck <linux@xxxxxxxxxxxx> >>> + >>> +description: | >>> + JEDEC JESD300-5B.01 SPD5118 Hub and Serial Presence Detect >>> + https://www.jedec.org/standards-documents/docs/jesd300-5b01 >>> + >>> +select: >>> + properties: >>> + compatible: >>> + const: jedec,spd5118 >> >> Why do you need the select? This s needed for cases with multiple >> bindings using parts of compatible list. I don't see the case here so far. >> > > Sorry, I am not a devicetree expert, I don't really know what I am doing, > and just copied this from some other binding. I'll try to find a better > example. Actually, I'll just add the binding to trivial devices. Sounds good. Best regards, Krzysztof