Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 15, 2024 at 05:28:24PM +0200, Dmitry Baryshkov wrote:
> On Wed, 15 May 2024 at 17:05, Prahlad Valluru <quic_vvalluru@xxxxxxxxxxx> wrote:
> >
> > On Wed, May 08, 2024 at 09:31:24AM -0500, Rob Herring (Arm) wrote:
> > >
> > > On Mon, 06 May 2024 18:14:10 -0500, Bjorn Andersson wrote:
> > > > On Fri, Apr 26, 2024 at 07:54:42PM GMT, Prahlad Valluru wrote:
> > > > > From: Venkata Prahlad Valluru <quic_vvalluru@xxxxxxxxxxx>
> > > > >
> > > >
> > > > Please don't thread new versions off existing version. b4 helps you with
> > > > getting these things right, please check go/upstream for more details.
> > > >
> > > > > Enable lt9611uxc bridge for qcs6490 rb3 gen2 platform.
> > > > >
> > > >
> > > > Even if it's clear what this is, I would prefer if you described the
> > > > hardware a little bit in your commit message.
> > > > "Rb3Gen2 has a HDMI connector, connected to DSI via a LT on i2cX.... reset and
> > > > irq pins comes from x and y. Describe this."
> > > >
> > > > > Signed-off-by: Prahlad Valluru <quic_vvalluru@xxxxxxxxxxx>
> > > > > ---
> > > > > v2: Addressed dtschema errors
> > > > >   - Fixed lt9611-irq
> > > > >   - vdd-supply error to be ignored, as it is connected to
> > > > >     input supply directly, on rb3gen2
> > >
> > > The choice is either fix the dts or fix the binding.
> >
> > vdd-supply is mandatory for lt9611. Only in case of rb3gen2, we are seeing this
> > error, since it is connected to supply directly. Will add dummy vreg to address this.
> 
> s/add dummy vreg/describe fixed hardware register/
True, will define a fixed regulator for vdd.
> 
> 
> -- 
> With best wishes
> Dmitry




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux