On Sat, May 25, 2024 at 02:11:05PM +0200, Markus Elfring wrote: > >>> Would you like to add an imperative wording for an improved change description? > >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94 > … > >> I'm happy to change it, but was going off the format used in Conor's Milkv Mars commit > >> https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/commit/?id=04a228aadb84d894721b13197649ca741f3018bc > > > > Don't worry about Markus, most maintainers (myself included) ignore his > > comments on patches. The commit message here is fine. > > Would such a response mean also that you are occasionally ignoring requirements > from a referenced Linux development guideline? I do ignore it from time to time, yes. Being a stickler to the guidelines wastes everybody's time (just like this discussion). That said, the tense used in this patch is perfectly in-line with the guideline you reference. "Add Star64 board devicetree" is in the imperative and the commit message body contains additional information about the board's configuration. Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
