Hi Krzysztof Kozlowski,
On 5/23/24 01:18, Krzysztof Kozlowski wrote:
+properties:
+ compatible:
+ enum:
+ - novatek,nvt-ts
That's too generic. Looking at your driver change, it is not even needed.
As suggested by Hans de Goede, I will fix the too generic issue in v2.
+ - novatek,nt36672a-ts
Eh, we have already panel. Why there is a need for touchscreen binding
(binding, not driver)?
I am not sure I understand this correctly. Help me a bit here. For
context, in mainline there is an existing driver for the novatek nvt
touchscreen controller. The driver did not have devicetree support. It
only had a i2c_device_id "NVT-ts". I don't know what is the variant of
I just got a bit confused that you add another binding for the same
device, but now I see these are different interfaces - DSI and I2C.
that Novatek touchscreen controller. To use the driver in Xiaomi Poco
F1, I introduced a devicetree compatible for it "novatek,nvt-ts". The
However, the Novatek touchscreen controller present in Xiaomi Poco F1 is
"NT36672A" which has a different chip id than the one in existing
driver. So I created a separate compatible for this touchscreen
controller variant "novatek,nt36672a-ts". I used compatible data to
differentiate the two variants. Since there are two variants, I am
mentioning both here.
Just to be clear, I don't care about driver here but hardware. You have
two separate interfaces on this hardware - DSI virtual channel and I2C?
Yes, there are two different interface in the hardware. The display
panel is connected via DSI and the touchscreen is connected via I2C
interface separately.
Best regards,
Krzysztof
Regards,
Joel Selvaraj
