On 21/05/2024 14:09, Joel Selvaraj via B4 Relay wrote: > From: Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx> > > Document the Novatek NVT touchscreen driver which is used in devices like driver? or device? > the Xiaomi Poco F1 [1]. Also, include the devictree binding file in the > MAINTAINERS file. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts?h=v6.9 > > Signed-off-by: Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx> > --- > .../bindings/input/touchscreen/novatek,nvt-ts.yaml | 62 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 63 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/novatek,nvt-ts.yaml b/Documentation/devicetree/bindings/input/touchscreen/novatek,nvt-ts.yaml > new file mode 100644 > index 0000000000000..7839c6a028e4a > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/novatek,nvt-ts.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/novatek,nvt-ts.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Novatek NVT Touchscreen Controller > + > +maintainers: > + - Hans de Goede <hdegoede@xxxxxxxxxx> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + enum: > + - novatek,nvt-ts That's too generic. Looking at your driver change, it is not even needed. > + - novatek,nt36672a-ts Eh, we have already panel. Why there is a need for touchscreen binding (binding, not driver)? > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + vcc-supply: true > + iovcc-supply: true > + > +unevaluatedProperties: false This goes after required: > + > +required: > + - compatible > + - reg > + - interrupts > + Best regards, Krzysztof
