Re: [PATCH 3/4] arm64: dts: mediatek: mt8365: drop incorrect power-domain-cells

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 20/05/24 12:03, Krzysztof Kozlowski ha scritto:
On 20/05/2024 11:58, AngeloGioacchino Del Regno wrote:
Il 18/05/24 23:11, Krzysztof Kozlowski ha scritto:
The top SCPSYS node is not a power domain provider.  It's child
"power-controller" is instead.  Fix dtbs_check warnings like:

    mt8365-evk.dtb: syscon@10006000: '#power-domain-cells' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Well if you're fixing that by migrating to scpsys compatible, you might as well
resolve all of the warnings in one commit, removing that power-domain-cells
property in patch [2/4], otherwise this one is technically a fix for that.

Please squash [2/4] and [3/4], like that it just makes more sense.


That's independent thing. Previous compatible - syscfg - also did not
allow power domains. The difference is that bindings did not print a
warning without my change. We can reverse the patches if this is more
suitable.


You're still introducing a warning with patch 2.

As for swapping the order, that could also be a solution, but I still don't see
that as an independent thing - in any case, swapping them is something I can do
while applying, eventually.







[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux