On 12/05/2024 10:28, devi priya wrote: > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pcie-ipq9574 > + then: > + properties: > + clocks: > + minItems: 6 > + maxItems: 6 > + clock-names: > + items: > + - const: ahb # AHB clock > + - const: aux # Auxiliary clock > + - const: axi_m # AXI Master clock > + - const: axi_s # AXI Slave clock > + - const: axi_bridge # AXI bridge clock > + - const: rchng That's introducing one more order of clocks... Please keep it consistent. The only existing case with ahb has it at after axi_m and others. Why making things everytime differently? I also to propose to finally drop the obvious comments, like "AHB clock". It cannot be anything else. AXI Master / slave are descriptive, so should stay. Best regards, Krzysztof