Re: [PATCH] dt-bindings: pwm: renesas,tpu: Do not require pwm-cells twice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 09, 2024 at 08:46:14AM -0500, Rob Herring wrote:
> On Tue, May 7, 2024 at 1:54 AM Binbin Zhou <zhoubinbin@xxxxxxxxxxx> wrote:
> >
> > pwm-cells property is already required by pwm.yaml schema.
> 
> This should be dropped or reverted.
> 
> > Suggested-by: Uwe Kleine-König <ukleinek@xxxxxxxxxx>
> > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
> > ---
> >
> > This is a missing patch to cleanup the required pwm-cells attribute twice[1].
> > Thanks to Uwe for the heads up.
> > [1]:https://lore.kernel.org/linux-pwm/cover.1714450308.git.zhoubinbin@xxxxxxxxxxx/
> >
> >  Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> > index a3e52b22dd18..4c8ce7a26d13 100644
> > --- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml
> > @@ -16,7 +16,6 @@ select:
> >          const: renesas,tpu
> >    required:
> >      - compatible
> > -    - '#pwm-cells'
> 
> This line is not requiring #pwm-cells, but rather only applying the
> schema when #pwm-cells is present. It is needed because there's also
> renesas,tpu in bindings/timer/renesas,tpu.yaml. Without this,
> linux-next now has these warnings:
> 
> [...]

Huh, indeed. I only grepped and didn't notice the context of the line. I
dropped the patch.

Sorry and thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux