On Tue, May 7, 2024 at 1:54 AM Binbin Zhou <zhoubinbin@xxxxxxxxxxx> wrote: > > pwm-cells property is already required by pwm.yaml schema. This should be dropped or reverted. > Suggested-by: Uwe Kleine-König <ukleinek@xxxxxxxxxx> > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > --- > > This is a missing patch to cleanup the required pwm-cells attribute twice[1]. > Thanks to Uwe for the heads up. > [1]:https://lore.kernel.org/linux-pwm/cover.1714450308.git.zhoubinbin@xxxxxxxxxxx/ > > Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml > index a3e52b22dd18..4c8ce7a26d13 100644 > --- a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml > +++ b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml > @@ -16,7 +16,6 @@ select: > const: renesas,tpu > required: > - compatible > - - '#pwm-cells' This line is not requiring #pwm-cells, but rather only applying the schema when #pwm-cells is present. It is needed because there's also renesas,tpu in bindings/timer/renesas,tpu.yaml. Without this, linux-next now has these warnings: /builds/robherring/linux-dt/Documentation/devicetree/bindings/timer/renesas,tpu.example.dtb: tpu@ffffe0: compatible:0: 'renesas,tpu' is not one of ['renesas,tpu-r8a73a4', 'renesas,tpu-r8a7740', 'renesas,tpu-r8a7742', 'renesas,tpu-r8a7743', 'renesas,tpu-r8a7744', 'renesas,tpu-r8a7745', 'renesas,tpu-r8a7790', 'renesas,tpu-r8a7791', 'renesas,tpu-r8a7792', 'renesas,tpu-r8a7793', 'renesas,tpu-r8a7794', 'renesas,tpu-r8a7795', 'renesas,tpu-r8a7796', 'renesas,tpu-r8a77961', 'renesas,tpu-r8a77965', 'renesas,tpu-r8a77970', 'renesas,tpu-r8a77980', 'renesas,tpu-r8a779a0', 'renesas,tpu-r8a779g0'] from schema $id: http://devicetree.org/schemas/pwm/renesas,tpu-pwm.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/timer/renesas,tpu.example.dtb: tpu@ffffe0: compatible: ['renesas,tpu'] is too short from schema $id: http://devicetree.org/schemas/pwm/renesas,tpu-pwm.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/timer/renesas,tpu.example.dtb: tpu@ffffe0: reg: [[16777184, 16], [16777200, 12]] is too long from schema $id: http://devicetree.org/schemas/pwm/renesas,tpu-pwm.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/timer/renesas,tpu.example.dtb: tpu@ffffe0: 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/pwm/renesas,tpu-pwm.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/timer/renesas,tpu.example.dtb: tpu@ffffe0: $nodename:0: 'tpu@ffffe0' does not match '^pwm(@.*|-([0-9]|[1-9][0-9]+))?$' from schema $id: http://devicetree.org/schemas/pwm/renesas,tpu-pwm.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/timer/renesas,tpu.example.dtb: tpu@ffffe0: '#pwm-cells' is a required property from schema $id: http://devicetree.org/schemas/pwm/renesas,tpu-pwm.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/timer/renesas,tpu.example.dtb: tpu@ffffe0: 'resets' is a required property from schema $id: http://devicetree.org/schemas/pwm/renesas,tpu-pwm.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/timer/renesas,tpu.example.dtb: tpu@ffffe0: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/pwm/renesas,tpu-pwm.yaml# Rob
