> -----Original Message----- > From: Conor Dooley <conor@xxxxxxxxxx> > Sent: Saturday, May 4, 2024 12:07 AM > To: Yuklin Soo <yuklin.soo@xxxxxxxxxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>; Bartosz Golaszewski > <bartosz.golaszewski@xxxxxxxxxx>; Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>; > Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>; Jianlong Huang > <jianlong.huang@xxxxxxxxxxxxxxxx>; Emil Renner Berthing <kernel@xxxxxxxx>; > Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > Drew Fustini <drew@xxxxxxxxxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > riscv@xxxxxxxxxxxxxxxxxxx; Paul Walmsley <paul.walmsley@xxxxxxxxxx>; Palmer > Dabbelt <palmer@xxxxxxxxxxx>; Albert Ou <aou@xxxxxxxxxxxxxxxxx> > Subject: Re: [RFC PATCH v3 1/7] dt-bindings: pinctrl: starfive: Add JH8100 pinctrl > > On Fri, May 03, 2024 at 07:14:30PM +0800, Alex Soo wrote: > > Add documentation and header file for JH8100 pinctrl driver. > > > > Signed-off-by: Alex Soo <yuklin.soo@xxxxxxxxxxxxxxxx> > > > diff --git a/include/dt-bindings/pinctrl/starfive,jh8100-pinctrl.h > > b/include/dt-bindings/pinctrl/starfive,jh8100-pinctrl.h > > new file mode 100644 > > index 000000000000..153ba950c062 > > --- /dev/null > > +++ b/include/dt-bindings/pinctrl/starfive,jh8100-pinctrl.h > > @@ -0,0 +1,13 @@ > > +/* SPDX-License-Identifier: GPL-2.0 OR MIT */ > > +/* > > + * Copyright (C) 2023-2024 StarFive Technology Co., Ltd. > > + */ > > + > > +#ifndef __DT_BINDINGS_PINCTRL_STARFIVE_JH8100_H__ > > +#define __DT_BINDINGS_PINCTRL_STARFIVE_JH8100_H__ > > + > > +/* Pad Slew Rates */ > > +#define PAD_SLEW_RATE_FAST 1 > > +#define PAD_SLEW_RATE_SLOW 0 > > Should this really be in the bindings? I don't see it having a direct user in the > driver. > > Also, if this is the only header you have, I think the RFC tag could be dropped, > since there'll not be a header we need to worry about getting into U-Boot etc > with values that may change when the SoC moves from an FPGA etc to tape out. I will drop the PAD_SLEW_RATE_* macros from dt-bindings header and move them to the DTS header file. Will submit the next version (V4) without the "RFC PATCH" subject prefix. > > Cheers, > Conor.
