On 06/05/2024 19:10, Frank Wunderlich wrote: > Hi > >> Gesendet: Montag, 06. Mai 2024 um 10:18 Uhr >> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxx> >> An: "Frank Wunderlich" <linux@xxxxxxxxx>, "Rob Herring" <robh@xxxxxxxxxx>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@xxxxxxxxxx>, "Conor Dooley" <conor+dt@xxxxxxxxxx>, "Michael Turquette" <mturquette@xxxxxxxxxxxx>, "Stephen Boyd" <sboyd@xxxxxxxxxx>, "Pavel Machek" <pavel@xxxxxx>, "Lee Jones" <lee@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, "Eric Dumazet" <edumazet@xxxxxxxxxx>, "Jakub Kicinski" <kuba@xxxxxxxxxx>, "Paolo Abeni" <pabeni@xxxxxxxxxx>, "Matthias Brugger" <matthias.bgg@xxxxxxxxx>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx> >> Cc: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, "Eric Woudstra" <ericwouds@xxxxxxxxx>, "Tianling Shen" <cnsztl@xxxxxxxxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx >> Betreff: Re: [RFC v1 1/5] dt-bindings: leds: add led trigger netdev >> >> On 05/05/2024 18:45, Frank Wunderlich wrote: >>> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >>> >>> Add led trigger implemented with config-symbol LEDS_TRIGGER_NETDEV to >>> binding. >>> >>> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/leds/common.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml >>> index 8a3c2398b10c..bf9a101e4d42 100644 >>> --- a/Documentation/devicetree/bindings/leds/common.yaml >>> +++ b/Documentation/devicetree/bindings/leds/common.yaml >>> @@ -113,6 +113,8 @@ properties: >>> # LED indicates NAND memory activity (deprecated), >>> # in new implementations use "mtd" >>> - nand-disk >>> + # LED indicates network activity >>> + - netdev >> >> "dev" is redundant (there is no flash-dev or usb-host-dev). Two network >> interfaces are already provided, so your commit msg must provide >> rationale why this is not enough and why this is useful/needed. > > i only see 1 network binding...and this is labeled/described with wlan and phy > > # LED is triggered by WLAN activity > - pattern: "^phy[0-9]+tx$" > > which second do you mean? > > btw. usb + disk has 3 trigger and "netdev" is already used in some dts, so i thought adding the binding is a good idea > > arch/arm/boot/dts/rockchip/rk3128-xpi-3128.dts:107: * linux,default-trigger = "netdev"; > arch/arm/boot/dts/nxp/imx/imx53-m53menlo.dts:52: linux,default-trigger = "netdev"; > arch/arm/boot/dts/intel/ixp/intel-ixp42x-dlink-dsm-g600.dts:51: linux,default-trigger = "netdev"; > arch/arm/boot/dts/intel/ixp/intel-ixp42x-iomega-nas100d.dts:39: linux,default-trigger = "netdev"; > arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts:138: linux,default-trigger = "netdev"; > arch/arm/boot/dts/ti/omap/am335x-netcan-plus-1xx.dts:27: linux,default-trigger = "netdev"; > arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts:107: linux,default-trigger = "netdev"; > arch/mips/boot/dts/ralink/gardena_smart_gateway_mt7688.dts:113: linux,default-trigger = "netdev"; > Then please check previous discussions: https://lore.kernel.org/all/20230217230346.GA2217008-robh@xxxxxxxxxx/ Best regards, Krzysztof
