Re: [PATCH 2/6] ASoC: max98088: Add DT bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello.

On 02/18/2015 09:25 PM, Andreas Färber wrote:

"maxim,max98089" will be used for the Spring Chromebook.

Signed-off-by: Andreas Färber <afaerber@xxxxxxx>
---
  sound/soc/codecs/max98088.c | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index 805b3f8cd39d..69a21d1946e3 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -2009,10 +2009,18 @@ static const struct i2c_device_id max98088_i2c_id[] = {
  };
  MODULE_DEVICE_TABLE(i2c, max98088_i2c_id);

+static const struct of_device_id max98088_of_match[] = {

If I don't mistake, gcc will complain about this variable being unused if CONFIG_OF=n.

+	{ .compatible = "maxim,max98088" },
+	{ .compatible = "maxim,max98089" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, max98088_of_match);
+
  static struct i2c_driver max98088_i2c_driver = {
  	.driver = {
  		.name = "max98088",
  		.owner = THIS_MODULE,
+		.of_match_table = of_match_ptr(max98088_of_match),

You probably don;t need of_match_ptr(). Either that or do something with the match table, like enclosing into #ifdef or annotating with '__maybe_unused'.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux