On 4/25/24 18:18, Rob Herring wrote:
On Wed, Apr 24, 2024 at 10:24:47PM +0200, Peter Korsgaard wrote:
Similar to target-rpm from fan-common.yaml but for the default PWM setting
(0..255).
Signed-off-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>
---
Changes since v1:
- Rename to default-pwm
Documentation/devicetree/bindings/hwmon/pwm-fan.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
index 4e5abf7580cc..70f062b30985 100644
--- a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
@@ -46,6 +46,14 @@ properties:
"#cooling-cells": true
+ default-pwm:
+ description:
+ The default fan PWM to use.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 255
+ default: 255
See my comments on v1. Please give time for other reviewers a chance to
comment.
Sorry. As far as I can see, Guenter explained why we cannot generically
translate between a default PWM value and RPM.
Do you still want to move this default-pwm property to fan-common.yaml?
If so, I can send a v3 doing that.
--
Bye, Peter Korsgaard
