Hello,
On Wed, Apr 24, 2024 at 12:32:36PM +0200, Jerome Brunet wrote:
> > +err:
> > + while (--i >= 0) {
> > + channel = &meson->channels[i];
> > + clk_put(channel->clk);
>
> Fine on error but leaks on module unload.
>
> Same as George,
>
> Add the devm variant of of_clk_get() if you must.
There shouldn't be a reason to still use of_clk_get(). I'd expect that
devm_clk_get() should do the job and if not that's a bug.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
