Hi Doug, thank you! We had reported this info to the CSOT to correct the vendor id. If they confirm to fix this with the same product ID, we will submit a patch to fix this. Doug Anderson <dianders@xxxxxxxxxxxx> 于2024年4月24日周三 01:01写道： > > Hi, > > On Mon, Apr 22, 2024 at 6:28 PM Xuxin Xiong > <xuxinxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > Yes, I read the edid from the panels, one is CSO and the other is CSW. > > The details are as follows, please help check. Thank you! > > > > > > 1. MNC207QS1-1 > > edid-decode (hex): > > 00 ff ff ff ff ff ff 00 0e 6f 00 12 e7 00 00 00 > > 1e 21 01 04 a5 1b 12 78 03 8a d5 9c 5e 59 90 25 > > 1b 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > > 01 01 01 01 01 01 ae 3f 80 18 71 b0 23 40 30 20 > > 36 00 07 a4 10 00 00 1a 00 00 00 fd 00 28 3c 4b > > 4b 11 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43 > > 53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe > > 00 4d 4e 43 32 30 37 51 53 31 2d 31 0a 20 00 32 > > ---------------- > > Block 0, Base EDID: > > EDID Structure Version & Revision: 1.4 > > Vendor & Product Identification: > > Manufacturer: CSO > > Model: 4608 > > Serial Number: 231 > > Made in: week 30 of 2023 > > Basic Display Parameters & Features: > > Digital display > > Bits per primary color channel: 8 > > DisplayPort interface > > Maximum image size: 27 cm x 18 cm > > Gamma: 2.20 > > Supported color formats: RGB 4:4:4 > > First detailed timing includes the native pixel format and preferred refresh rate > > Display is continuous frequency > > Color Characteristics: > > Red : 0.6113, 0.3671 > > Green: 0.3496, 0.5644 > > Blue : 0.1474, 0.1064 > > White: 0.3134, 0.3291 > > Established Timings I & II: none > > Standard Timings: none > > Detailed Timing Descriptors: > > DTD 1: 1920x1200 60.000 Hz 8:5 74.100 kHz 163.020 MHz (263 mm x 164 mm) > > Hfront 48 Hsync 32 Hback 200 Hpol P > > Vfront 3 Vsync 6 Vback 26 Vpol N > > Display Range Limits: > > Monitor ranges (Bare Limits): 40-60 Hz V, 75-75 kHz H, max dotclock 170 MHz > > Alphanumeric Data String: 'CSOT T9' > > Alphanumeric Data String: 'MNC207QS1-1' > > Checksum: 0x32 > > > > 2. MNB601LS1-1 > > edid-decode (hex): > > > > 00 ff ff ff ff ff ff 00 0e 77 00 11 00 00 00 00 > > 00 22 01 04 95 1a 0e 78 03 a1 35 9b 5e 58 91 25 > > 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > > 01 01 01 01 01 01 09 1e 56 dc 50 00 28 30 30 20 > > 36 00 00 90 10 00 00 1a 00 00 00 fd 00 28 3c 30 > > 30 08 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43 > > 53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe > > 00 4d 4e 42 36 30 31 4c 53 31 2d 31 0a 20 00 37 > > ---------------- > > Block 0, Base EDID: > > EDID Structure Version & Revision: 1.4 > > Vendor & Product Identification: > > Manufacturer: CSW > > Model: 4352 > > Made in: 2024 > > Basic Display Parameters & Features: > > Digital display > > Bits per primary color channel: 6 > > DisplayPort interface > > Maximum image size: 26 cm x 14 cm > > Gamma: 2.20 > > Supported color formats: RGB 4:4:4 > > First detailed timing includes the native pixel format and preferred refresh rate > > Display is continuous frequency > > Color Characteristics: > > Red : 0.6074, 0.3691 > > Green: 0.3437, 0.5673 > > Blue : 0.1445, 0.1123 > > White: 0.3134, 0.3291 > > Established Timings I & II: none > > Standard Timings: none > > Detailed Timing Descriptors: > > DTD 1: 1366x768 60.001 Hz 683:384 48.480 kHz 76.890 MHz (256 mm x 144 mm) > > Hfront 48 Hsync 32 Hback 140 Hpol P > > Vfront 3 Vsync 6 Vback 31 Vpol N > > Display Range Limits: > > Monitor ranges (Bare Limits): 40-60 Hz V, 48-48 kHz H, max dotclock 80 MHz > > Alphanumeric Data String: 'CSOT T9' > > Alphanumeric Data String: 'MNB601LS1-1' > > Checksum: 0x37 > > OK. This made me look a little deeper. I believe that the three-letter > code is managed by UEFI and I found: > > https://uefi.org/PNP_ID_List > > ...as far as I can tell "CSW" is actually correct for CSOT but "CSO" > was _not_. Looks as if CSO was supposed to be for "California > Institute of Technology" (Caltech). :( > > We're probably OK with the recent work that Hsin-Yi did in commit > bf201127c1b8 ("drm/panel-edp: Match edp_panels with panel identity") > to match against the panel name even if Caltech does ship a "CSO" > 0x1200 in the future since it looks like the string you added matches > the panel. > > That being said, is there any chance that it's not too late and you > can get CSOT to fix the EDID on "MNC207QS1-1"? Can you also make sure > that they're aware of this and don't make the same mistake in the > future? > > > In any case, given this investigation and the EDID I'm going to say > that the panel you've added here is fine. > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > I've pushed your change to drm-misc-next: > > a6325ad47bc8 drm/panel-edp: Add panel CSOT MNB601LS1-1 > > -Doug
