On 09/04/2024 17:55, Krzysztof Kozlowski wrote:
+
+additionalProperties: false
+
+examples:
+ - |
+ codec {
+ mediatek,micbias0-microvolt = <1900000>;
+ mediatek,micbias1-microvolt = <1700000>;
+ mediatek,vaud28-supply = <&mt6357_vaud28_reg>;
Sorry, this does not work. Change voltage to 1111111 and check the results.
Actually it's worst ! I've removed the required property (vaud28-supply) but the dt check pass.
Same behavior for some other docs like mt6359.yaml
The at24.yaml doc works as expected, then I tried compare an find the issue, without success...
I've replaced "codec" by "audio-codec", according to [1].
I've tried multiple manner to implement the example code, without success. I'm wondering if what I
try to do is the correct way or parse-able by the dt_check.
If I drop this file and implement all these new properties into the MFD PMIC documentation directly,
I've the expected dt_check result (function to good or wrong parameters)
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml
@@ -37,9 +37,32 @@ properties:
"#interrupt-cells":
const: 2
- codec:
+ audio-codec:
type: object
- $ref: /schemas/sound/mt6357.yaml
+ properties:
+ vaud28-supply:
+ description: 2.8 volt supply phandle for the audio codec
+
+ mediatek,hp-pull-down:
+ description:
+ Earphone driver positive output stage short to
+ the audio reference ground.
+ type: boolean
+
+ mediatek,micbias0-microvolt:
+ description: Selects MIC Bias 0 output voltage.
+ enum: [1700000, 1800000, 1900000, 2000000,
+ 2100000, 2500000, 2600000, 2700000]
+ default: 1700000
+
+ mediatek,micbias1-microvolt:
+ description: Selects MIC Bias 1 output voltage.
+ enum: [1700000, 1800000, 1900000, 2000000,
+ 2100000, 2500000, 2600000, 2700000]
+ default: 1700000
+
+ required:
+ - vaud28-supply
unevaluatedProperties: false
regulators:
@@ -88,6 +111,12 @@ examples:
interrupt-controller;
#interrupt-cells = <2>;
+ audio-codec {
+ mediatek,micbias0-microvolt = <1700000>;
+ mediatek,micbias1-microvolt = <1700000>;
+ vaud28-supply = <&mt6357_vaud28_reg>;
+ };
+
regulators {
Is the implementation above looks good for you ?
[1]
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
--
Regards,
Alexandre
