On Tue, Apr 16, 2024 at 02:10:32PM +0200, Stefan Eichenberger wrote: > Add a new device tree property to disable SGMII autonegotiation and > instead use the option to match the SGMII speed to what was negotiated > on the twisted pair interface (tpi). This allows us to disable SGMII > autonegotiation on Ethernet controllers that are not compatible with > this mode. > > Signed-off-by: Stefan Eichenberger <eichest@xxxxxxxxx> > --- > drivers/net/phy/mxl-gpy.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c > index b2d36a3a96f1..4147b4c29eaf 100644 > --- a/drivers/net/phy/mxl-gpy.c > +++ b/drivers/net/phy/mxl-gpy.c > @@ -114,6 +114,7 @@ struct gpy_priv { > * is enabled. > */ > u64 lb_dis_to; > + bool sgmii_match_tpi_speed; > }; > > static const struct { > @@ -262,8 +263,17 @@ static int gpy_mbox_read(struct phy_device *phydev, u32 addr) > > static int gpy_config_init(struct phy_device *phydev) > { > + struct gpy_priv *priv = phydev->priv; > int ret; > > + /* Disalbe SGMII Autoneg if we want to match SGMII to TPI speed */ nit: Disable