Re: [RFC PATCH v2 2/6] dt-bindings: mfd: bd96801 PMIC core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/18/24 20:28, Krzysztof Kozlowski wrote:
On 15/04/2024 10:28, Matti Vaittinen wrote:

Missing allOf and $ref to watchdog.yaml

Huh. The watchdog.yaml contains:

select:
    properties:
      $nodename:
        pattern: "^watchdog(@.*|-([0-9]|[1-9][0-9]+))?$"

properties:
    $nodename:
      pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"


This means the watchdog _must_ have own sub-node inside the PMIC node,

Yes, that's a bit of a trouble.

Agree. I'm not 100% sure why this requirement? I guess it is a bit of a problem for many MFD devices with a watchdog.

Then instead maybe just add timeout-sec
with maxItems: 2.

Nice idea. Thanks for the suggestion, I'll do just that!

Yours,
	-- Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux