Re: [RFC PATCH v2 2/6] dt-bindings: mfd: bd96801 PMIC core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/14/24 00:33, Krzysztof Kozlowski wrote:
On 12/04/2024 13:21, Matti Vaittinen wrote:
ROHM BD96801 is a highly configurable automotive grade PMIC. Introduce
DT bindings for the BD96801 core.

Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

---
Revision history:
RFCv1 => RFCv2:
   - Document rohm,hw-timeout-ms
   - Document rohm,wdg-action
---
  .../bindings/mfd/rohm,bd96801-pmic.yaml       | 171 ++++++++++++++++++
  1 file changed, 171 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml

diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml

...


Missing allOf and $ref to watchdog.yaml

Huh. The watchdog.yaml contains:

select:
  properties:
    $nodename:
      pattern: "^watchdog(@.*|-([0-9]|[1-9][0-9]+))?$"

properties:
  $nodename:
    pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"


This means the watchdog _must_ have own sub-node inside the PMIC node, right?

Yours,
	-- Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux