On 17/04/2024 10:17, Mohammad Rafi Shaik wrote: > On 4/16/2024 8:02 PM, Rob Herring wrote: >> On Tue, Apr 16, 2024 at 12:05:55PM +0530, Mohammad Rafi Shaik wrote: >>> From: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx> >>> >>> Qualcomm WCD9370/WCD9375 Codec is a standalone Hi-Fi audio codec IC >>> connected over SoundWire. This device has two SoundWire devices RX and >>> TX respectively. >>> This binding is for those slave devices on WCD9370/WCD9375. >>> >>> Co-developed-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx> >>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx> >>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx> >>> --- >>> .../bindings/sound/qcom,wcd937x-sdw.yaml | 71 +++++++++++++++++++ >>> 1 file changed, 71 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml >>> new file mode 100644 >>> index 000000000000..2b7358e266ba >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml >>> @@ -0,0 +1,71 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/sound/qcom,wcd937x-sdw.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm SoundWire Slave devices on WCD9370 >>> + >>> +maintainers: >>> + - Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> >>> + >>> +description: | >> >> Don't need '|' if no formatting. >> >>> + Qualcomm WCD9370 Codec is a standalone Hi-Fi audio codec IC. >>> + It has RX and TX Soundwire slave devices. This bindings is for the >>> + slave devices. >>> + >>> +properties: >>> + compatible: >>> + const: sdw20217010a00 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + qcom,tx-port-mapping: >>> + description: | >>> + Specifies static port mapping between slave and master tx ports. >>> + In the order of slave port index. >> >> Are there constraints on the values of the entries? > > The port mapping entries are fixed values. > There is no constraints. If they are fixed, then for sure you have constraints, because they are known. I really do not understand your response. Best regards, Krzysztof