On 17/04/2024 00:39, Christophe JAILLET wrote:
Le 16/04/2024 à 07:27, Chanh Nguyen a écrit :
On 14/04/2024 15:03, Christophe JAILLET wrote:
Le 14/04/2024 à 06:22, Chanh Nguyen a écrit :
PWMOUT pins on MAX31790 can be configured as a tachometer input pin by
setting bit[0] in the Configuration Register. When the bit[0] of a
channel
is set, the PWMOUT pin becomes the tach input pin for the channel
plus six.
This commit allows the kernel to set those pins when necessary if the
maxim,pwmout-pin-as-tach-input DT property exists.
Signed-off-by: Chanh Nguyen <chanh@xxxxxxxxxxxxxxxxxxxxxx>
---
Changes in v2:
- Update the vendor property name to
"maxim,pwmout-pin-as-tach-input" [Rob]
...
Hi CJ, what does it mean?
Hi,
just a shortcut of my name : Christophe Jaillet.
Thank CJ! It's a pleasure to see your comments. I'm happy to meet your
review in the next patches.
Best Regards,
Chanh Ng
CJ
@@ -528,6 +532,33 @@ static int max31790_probe(struct i2c_client
*client)
if (err)
return err;
+ if (device_property_present(dev,
"maxim,pwmout-pin-as-tach-input")) {
+ err = device_property_read_u8_array(dev,
"maxim,pwmout-pin-as-tach-input",
+ pwmout_to_tach, NR_CHANNEL);
+ if (err) {
+ /* The maxim,pwmout-pin-as-tach-input is an array of
six values */
+ dev_warn(dev, "The maxim,pwmout-pin-as-tach-input
property exist but malform");
Nit: exists
Nit: malformed or "is malformed"
Thank CJ,
I'll update that in the patch v3
CJ
