Hi André,
Thanks for the review.
On Fri, 5 Apr 2024 at 08:38, André Draszik <andre.draszik@xxxxxxxxxx> wrote:
>
> On Thu, 2024-04-04 at 13:25 +0100, Peter Griffin wrote:
> > Enable the cmu_hsi2 clock management unit. It feeds some of
> > the high speed interfaces such as PCIe and UFS.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > index eddb6b326fde..38ac4fb1397e 100644
> > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > @@ -1253,6 +1253,18 @@ pinctrl_hsi1: pinctrl@11840000 {
> > interrupts = <GIC_SPI 471 IRQ_TYPE_LEVEL_HIGH 0>;
> > };
> >
> > + cmu_hsi2: clock-controller@14400000 {
> > + compatible = "google,gs101-cmu-hsi2";
> > + reg = <0x14400000 0x4000>;
> > + #clock-cells = <1>;
> > + clocks = <&ext_24_5m>,
> > + <&cmu_top CLK_DOUT_CMU_HSI2_BUS>,
> > + <&cmu_top CLK_DOUT_CMU_HSI2_PCIE>,
> > + <&cmu_top CLK_DOUT_CMU_HSI2_UFS_EMBD>,
> > + <&cmu_top CLK_DOUT_CMU_HSI2_MMC_CARD>;
> > + clock-names = "oscclk", "bus", "pcie", "ufs_embd", "mmc_card";
> > + };
>
> This doesn't build because you didn't add the clock ids in the binding patch.
These clock IDs are for cmu_top, not cmu_hsi2. They were added as part
of the initial gs101/Oriole upstream support series in the following
commit
commit 0a910f1606384a5886a045e36b1fc80a7fa6706b
Author: Peter Griffin <peter.griffin@xxxxxxxxxx>
Date: Sat Dec 9 23:30:48 2023 +0000
dt-bindings: clock: Add Google gs101 clock management unit bindings
Provide dt-schema documentation for Google gs101 SoC clock controller.
Currently this adds support for cmu_top, cmu_misc and cmu_apm.
Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20231209233106.147416-3-peter.griffin@xxxxxxxxxx
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
regards,
Peter
