On 15/04/2024 04:31, Binbin Zhou wrote: > The temperature output register of the Loongson-2K2000 is defined in the > chip configuration domain, which is different from the Loongson-2K1000, > so it can't be fallbacked. > > We need to use two groups of registers to describe it: the first group > is the high and low temperature threshold setting register; the second > group is the temperature output register. > > It is true that this fix will cause ABI corruption, but it is necessary > otherwise the Loongson-2K2000 temperature sensor will not work properly. > > Fixes: 72684d99a854 ("thermal: dt-bindings: add loongson-2 thermal") > Cc: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > --- > .../thermal/loongson,ls2k-thermal.yaml | 23 +++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml > index 9748a479dcd4..fac6f64d6c67 100644 > --- a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml > @@ -18,14 +18,15 @@ properties: > oneOf: > - enum: > - loongson,ls2k1000-thermal > + - loongson,ls2k2000-thermal > - items: > - enum: > - loongson,ls2k0500-thermal > - - loongson,ls2k2000-thermal > - const: loongson,ls2k1000-thermal > > reg: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > > interrupts: > maxItems: 1 > @@ -41,6 +42,24 @@ required: > > unevaluatedProperties: false > > +if: This goes before unevaluatedProperties, just like in example schema. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof