Hi Bjorn, On 4/9/2024 8:47 PM, Bjorn Andersson wrote: > On Wed, Apr 03, 2024 at 06:58:39PM +0530, Umang Chheda wrote: >> The Volume Down & Power buttons are controlled by the PMIC via >> the PON hardware, and the Volume Up is connected to a PMIC gpio. >> >> Enable the necessary hardware and setup the GPIO state for the >> Volume Up gpio key. >> >> Signed-off-by: Umang Chheda <quic_uchheda@xxxxxxxxxxx> >> --- > > I suppose this isn't a "resend" either, so please send me a new version > of this as well. > I had earlier sent [1] for review, on which I hadn't received any review comments. Hence, I resent this patch again after 2 weeks for review. [1] https://lore.kernel.org/linux-arm-msm/20240320121016.2878367-1-quic_uchheda@xxxxxxxxxxx/ Regards, Umang > Regards, > Bjorn > >> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 37 ++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> index 63ebe0774f1d..73f6d18d2331 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> @@ -9,6 +9,8 @@ >> #define PM7250B_SID 8 >> #define PM7250B_SID1 9 >> >> +#include <dt-bindings/input/linux-event-codes.h> >> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> #include "sc7280.dtsi" >> #include "pm7250b.dtsi" >> @@ -39,6 +41,22 @@ chosen { >> stdout-path = "serial0:115200n8"; >> }; >> >> + gpio-keys { >> + compatible = "gpio-keys"; >> + >> + pinctrl-0 = <&key_vol_up_default>; >> + pinctrl-names = "default"; >> + >> + key-volume-up { >> + label = "Volume_up"; >> + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>; >> + linux,code = <KEY_VOLUMEUP>; >> + wakeup-source; >> + debounce-interval = <15>; >> + linux,can-disable; >> + }; >> + }; >> + >> reserved-memory { >> xbl_mem: xbl@80700000 { >> reg = <0x0 0x80700000 0x0 0x100000>; >> @@ -471,6 +489,25 @@ &gcc { >> <GCC_WPSS_RSCP_CLK>; >> }; >> >> +&pm7325_gpios { >> + key_vol_up_default: key-vol-up-state { >> + pins = "gpio6"; >> + function = "normal"; >> + input-enable; >> + bias-pull-up; >> + qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>; >> + }; >> +}; >> + >> +&pon_pwrkey { >> + status = "okay"; >> +}; >> + >> +&pon_resin { >> + linux,code = <KEY_VOLUMEDOWN>; >> + status = "okay"; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> -- >> 2.25.1 >>
