> -----Original Message----- > From: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > Sent: 2024年4月10日 15:40 > To: Joy Zou <joy.zou@xxxxxxx> > Cc: Jacky Bai <ping.bai@xxxxxxx>; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > imx@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx > <linux-imx@xxxxxxx>; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc > PCF2131 support > On 24-04-10, Joy Zou wrote: > > Support rtc PCF2131 on imx93-11x11-evk. > > > > Signed-off-by: Joy Zou <joy.zou@xxxxxxx> > > --- > > Changes in v3: > > 1.adjust the indentation. > > > > Changes in v2: > > 1. remove unnecessary status property. > > --- > > .../boot/dts/freescale/imx93-11x11-evk.dts | 24 > +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > index 07e85a30a25f..73e0bca36b81 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > > @@ -281,6 +281,23 @@ ldo5: LDO5 { > > }; > > }; > > > > +&lpi2c3 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + clock-frequency = <400000>; > > + pinctrl-names = "default", "sleep"; > > + pinctrl-0 = <&pinctrl_lpi2c3>; > > + pinctrl-1 = <&pinctrl_lpi2c3>; > > Are both "default" and "sleep" pinctrl's required? It doesn't make any sense > to provde a sleep state which uses the same pinctrl state. Thanks for your comments! Currently, We only use default. Yeah, It's confused that a sleep state which uses the same pinctrl state. So will remove the sleep. BR Joy Zou > > Regards, > Marco >