On 09/04/2024 17:46, Krzysztof Kozlowski wrote:
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ afe@11220000 {
Did you implement the comment or decided to keep afe?
Though it was clear according to [1]:
"
Audio Front End, this is the same name used for other MTK SoC, to be
consistent.
Cook a new patch serie to change "afe" by "audio-controller" for all MTK
SoC would be great.
"
I want to keep it and fix it later with ALL other MTK SoC.
You didn't answer after that, I though it was ok for you...
So if you don't agree with that, just tell me to change it instead of
let me think I've the choice.
BTW, whatever "consistency" you have in mind, it does not really matter
that much for that example. And for sure do not add incorrect code
intentionally just to fix it in next patch.
I don't get your point.
What do you mean by "do not add incorrect code intentionally" please ???
My PoV: I implement my bindings aligned to ALL other MTK SoC, which have
been validated by you in the past. I can understand the copied code is
wrong, but I've suggested a solution and you didn't NACK it.
I fell like you bully me. Are you ok to stop insinuating bad things
please and tell me directly if a fix is mandatory and if you are waiting
for a specific one, tell me directly to avoid this kind of unpleasant
talk and waste of time, I know maintainers are busy persons.
Beside that, thanks for your reviews.
[1]:
https://lore.kernel.org/all/eeb3329b-0558-4237-8343-4e11f65a6a35@xxxxxxxxxxxx/
--
Regards,
Alexandre
