Il 09/04/24 13:42, AngeloGioacchino Del Regno ha scritto:
The regulators' node names for mt6360-regulator are supposed to be uppercase. Also, drop "-regulator" from the usb-otg-vbus node name to make all vregs to probe correctly. The alternative would've been to use regulator-compatible, but that's a deprecated property. Now all regulators are probing fine. Fixes: 96564b1e2ea4 ("arm64: dts: mediatek: Introduce the MT8395 Radxa NIO 12L board") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> --- .../boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts index e5d9b671a405..18182cf073fb 100644 --- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts +++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts @@ -216,7 +216,7 @@ charger { compatible = "mediatek,mt6360-chg"; richtek,vinovp-microvolt = <14500000>;- otg_vbus_regulator: usb-otg-vbus-regulator {+ otg_vbus_regulator: usb-otg-vbus {
Reviewing and NACK'ing my own patch, I just noticed that everything apart the usb-otg-vbus renaming is wrong. The MT6360 regulator node names should not be capitalized as the bindings are correct in this regard, and there already is one user (genio-1200-evk) apart from NIO-12L declaring the wrong ones - so, the driver must be fixed, not the other way around. This patch will be cleaned up in v2. Cheers
