On Tue, Apr 09, 2024 at 01:13:32PM +0100, Conor Dooley wrote: > On Tue, Apr 09, 2024 at 03:17:35PM +0800, Inochi Amaoto wrote: > > On Tue, Apr 09, 2024 at 08:45:04AM +0200, michael.opdenacker@xxxxxxxxxxx wrote: > > > From: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxx> > > > > > > This adds initial support for the Milk-V Duo S board > > > (https://milkv.io/duo-s), enabling the serial port and > > > read-only SD card support, allowing to boot Linux to the > > > command line. > > > > > > > Hi Michael, > > > > I think your patch losts the board binding and have wrong compatiable. > > Also, the SD can have rw support with proper property. See link [1] > > (need 'disable-wp'). > > [1] doesn't go anywhere useful. > This is my fault, I copied the wrong url. The right patch is https://lore.kernel.org/r/20240217144826.3944-1-jszhang@xxxxxxxxxx. > > I suggest you resubmitting this patch after applying clk patchs. > > This could reduce some unnecessary change. For now, you can just > > use the dts for huashan-pi (with changed memory size). > > Why would using patched huashan-pi dts be more suitable than carrying > a local patch for duo-s devicetree? What am I missing? > > Cheers, > Conor. > > > > > [1]: https://lore.kernel.org/linux-riscv/IA1PR20MB4953B158F6F575840F3D4267BB7D2@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ I think you miss nothing. Using huashan-pi dts as a temporary solution is just because they are both CV181X series. Since only a few peripherals are supported, it is also OK to use duo dts with local change. They're not significantly different. This is also the reason I did not prepare any patch for the new board. (such as lichee RV NANO, duo 256).
